fix(spf): align subscriber location framing with relay 0.14.17

Merged
MM
2mo ago
+113-77

Refs #45

Summary

moq-relay 0.14.17 sends LARGEST_OBJECT as two bare varints on draft-20. The previous length-prefixed decoder rejected SUBSCRIBE_OK once a track had content, closing the playback session. Use the existing bare Location helpers for both encoding and decoding.

Changes

  • Pin message-parameter, SUBSCRIBE_OK, and REQUEST_OK wire vectors, including multi-byte IDs, trailing parameters/properties, and truncated locations.
  • Preserve INCLUDE_PROPERTIES framing and update the migration notes with the coordinated relay cutover and live-test evidence.

This codec change must ship with the relay upgrade: older relays' length-prefixed locations are incompatible, and the forms cannot be safely auto-detected.

Testing

  • Network and playback behavior suites: 675 tests passed.
  • Four new wire regressions fail against the original codec; the fixed codec suite passes all 45 tests.
  • SPF build, SPF project type check, changed-file lint/format checks, and pnpm check:workspace passed.
  • Live WebTransport pass using both fix worktrees against moqdev/moq-relay:0.14.17: a late subscriber decoded Largest Object {255,128} and received all 129 cached objects. This used synthetic payloads and verifies protocol delivery, not media decoding.

The same live pass exposed a separate publisher re-subscription limitation in Chromium without writer.commit(); browser-compatible fill serving is tracked in #46.


Summary by cubic

Fixes #45 by matching moq-relay 0.14.17's draft-20 framing for LARGEST_OBJECT. The old length-prefixed decoder rejected SUBSCRIBE_OK once a track had content, closing playback sessions; the codec now encodes and decodes LARGEST_OBJECT as two bare varints.

Bug Fixes

  • Updated SUBSCRIBE_OK and REQUEST_OK wire vectors, including multi-byte IDs, trailing parameters/properties, and truncated locations.
  • Preserved INCLUDE_PROPERTIES length-prefixed framing, which is unchanged in 0.14.17.
  • Live WebTransport test against moqdev/moq-relay:0.14.17 decoded Largest Object {255,128} and received all 129 cached objects.

Migration

  • This codec change must ship with the relay upgrade; old and new wire forms are incompatible and cannot be safely auto-detected.