Fix terminal logger encoding & error

Merged
NO
3y ago
+156-15

Description

  • Use UTF8 encoding for the output that we force in vstest.console unless the user opts out.
  • Don't forward unrecognized messages to the parser, instead write them as message. Otherwise any message with "error" in it will be written as error, including passed tests that say "Standard Error: "
  • Allow suppressing the logger also by MSBUILDENSURESTDOUTFORTASKPROCESSES=1

This PR is updating the dotnet SDK because the new SDK is NOT forcing MSBUILDENSURESTDOUTFORTASKPROCESSES=1 when the new logger is enabled. The old SDK was forcing it, and it would always disable the new task in our tests.

Related issue

Fix https://github.com/dotnet/msbuild/issues/9674
Fix https://github.com/microsoft/vstest/issues/4852