Ship Microsoft.Diagnostics.NETCore.Client in Microsoft.TestPlatform and Portable packages
Description
/Blame:CollectHangDump fails when the Microsoft.TestPlatform package console (net462) drives a .NET testhost:
Could not load file or assembly 'Microsoft.Diagnostics.NETCore.Client, Version=0.2.14.41219 ...'
Collect dump was enabled but no dump file was generated.
BlameDataCollector needs Microsoft.Diagnostics.NETCore.Client.dll to dump .NET testhosts, but only Microsoft.TestPlatform.CLI shipped it. Microsoft.TestPlatform and Microsoft.TestPlatform.Portable did not.
Now both packages put the DLL next to Microsoft.TestPlatform.Extensions.BlameDataCollector.dll. eng/expected-nupkg-file-counts.json and eng/expected-dll-frameworks.json are regenerated by a clean Release -pack build.
We did not catch it because HangDumpOnTimeout was pinned to the .NET console, which comes from the CLI package. It now runs with both consoles and both testhosts. Before the packaging change the net462 console + .NET testhost row failed with the error above, now all 4 rows pass (1m 30s).
Related issue
Reported by email, no issue filed.
- I have ensured that there is a previously discussed and approved issue.
š¤