[release/13.5] Fix deprecated Homebrew cask DSL usage

Merged
JO
1mo ago
+96-39

Description

Backport of #19965 to release/13.5, cherry-picked from 12847d472bd65282485fd102d449077e0bd66ff3.

Homebrew 6.x rejects the deprecated verified: cask URL parameter, blocking Homebrew validation on release-branch builds (including #20094 and #20110). This preserves the complete source fix: remove verified:, migrate postflight/File.write to postflight_steps/write_file, simplify dogfood URL rewriting, and remove obsolete brew audit --signing/--no-signing arguments.

Conflict resolutions

  • Omit main-only .github/workflows/homebrew-validate-release.yml; retain release/13.5's Azure DevOps HomebrewValidateJob and update both relevant pipeline comments.
  • Resolve docs/release-process.md and eng/homebrew/README.md using the release branch's existing orchestration, documenting the updated audit and explicit notarization gate without importing main's release-process migration.
  • Template, dogfood script, and regression tests match the source commit. The validation script differs only in its retained HomebrewValidateJob comment.

Security considerations

Preserves release-binary signature/notarization validation explicitly with codesign --verify -R=notarized --check-notarization on the installed Caskroom binary. Homebrew no longer runs its signing audit automatically for our temporary third-party tap. A failed notarization check remains fatal and invokes the existing uninstall/cleanup path. Regression coverage for invocation and failure cleanup is included; actual macOS verification was not run on this Windows host.

Fixes # (issue)

Customer Impact

Unblocks Homebrew cask preparation/validation for release/13.5 with current Homebrew, while preserving install-channel metadata and the release notarization gate. No public API changes.

Testing

  • Rebased onto release/13.5 tip bd4a8e2efccc86a00ba9ff0df890a326f0318146.
  • Acquisition test project built; PRScriptInstallerModeTests: 11 Windows-compatible tests passed, 0 failed.
  • Homebrew Bash tests are platform-excluded on Windows. A focused selection ran zero tests; these are not claimed as passing.
  • Git Bash bash -n passed for dogfood.sh, validate-cask-artifact.sh, and prepare-cask-artifact.sh.
  • git diff --check passed.
  • Real macOS Homebrew style/audit/install/notarization validation remains for CI/macOS. The source PR records successful Homebrew validation, but that is not release-branch validation.

Risk

Low: scoped to Homebrew packaging/validation, related tests, and documentation. Existing release orchestration and cleanup behavior are retained. Real Homebrew/macOS execution remains the principal validation gap.

Regression?

Compatibility regression with current Homebrew: release PR #19998 passed September 9, while #20094 and #20110 failed September 13–14 on the deprecated verified parameter. No specific Aspire-introduced regression has been identified.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No