Use existing prod profile secret for App Store workflow
Summary
- let the iOS App Store workflow use IOS_PROD_PROVISIONING_PROFILE_BASE64 when IOS_APPSTORE_PROVISIONING_PROFILE_BASE64 is absent
- keep the existing profile validation for com.cmuxterm.app, production APNs, and Sign in with Apple
Verification
- ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ios-app-store.yml"); puts "yaml ok"'\n\nNo app reload: workflow-only change.
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.
[!NOTE]
Low Risk
Workflow-only secret fallback with the same profile validation; no app or signing logic changes.
Overview
The iOS App Store workflow’s “Install App Store provisioning profile” step now resolves IOS_APPSTORE_PROVISIONING_PROFILE_BASE64 from IOS_APPSTORE_PROVISIONING_PROFILE_BASE64 or, if that secret is missing, from IOS_PROD_PROVISIONING_PROFILE_BASE64.
Decode, install, and plist checks (bundle id com.cmuxterm.app, production APNs, Sign in with Apple) are unchanged—only which secret supplies the profile bytes.
Reviewed by Cursor Bugbot for commit 257872cdc0ce31298105e40977bb04dcef27258d. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
App Store build workflow now falls back to IOS_PROD_PROVISIONING_PROFILE_BASE64 if IOS_APPSTORE_PROVISIONING_PROFILE_BASE64 is missing, preventing failed builds when the App Store secret isn’t set. Existing profile checks for com.cmuxterm.app, production APNs, and Sign in with Apple remain unchanged; CI-only updates with no app code changes.
Summary by CodeRabbit
- Bug Fixes
- Improved the iOS App Store build setup by automatically using the dedicated App Store provisioning profile secret when it’s available, with a fallback to the existing production provisioning profile secret when it isn’t.
- This helps prevent build/package failures when the preferred provisioning profile value is missing, while still erroring clearly if no provisioning profile is provided.