cmux NEXT updates: the download Leo starts shows its progress again; Restart to Update ignores a click right after it appears

Merged
TE
2d ago
+91-57

Leo-ask: ask-8112d98df7

Leo, 2026-11-04: "i only clicked the "download" button and it allegedly "updated" but i didnt restart the app/get a prompt to?", then: "the weird thing is that there's no more updating downloading progress bar for some reason? after i download... it got removed for some reason".

What changed

  • The download's progress is back on the sidebar. #33176 made every download quiet in the sidebar, including one the person asked for, and moved its progress to Settings > Updates. After a Download click the card disappeared, and about a minute later the Restart to Update card appeared in its place with nothing in between. Now a download the person asked for (Download or Update) shows its progress on the notice card again, with its Cancel, until the update is staged. A background download still shows nothing until the one Restart to Update card (the 2026-11-03 one-step design). Settings > Updates still shows the download too. UpdateFlow.card returns .downloading again when userAsked is set.
  • Restart to Update ignores a pointer click for 1 s after its card takes the slot (SidebarUpdateButton.ignorePointer, appearGuard). This covers a click that was already on its way to the card being replaced. Key and VoiceOver presses are never ignored. It is a stored deadline compared with NSEvent.timestamp, so there is no timer to stop or clean up.

Why it relaunched

The updater log from Leo's Mac (PST) has no crash. 17:04:14 Download click; 17:04:52 the download finished; 17:05:16 staged ("waiting for the user"); 17:05:19.671 "install click"; then the install and relaunch. So a click on Restart to Update came 3.3 s after that card appeared where the vanished download card had been. Nothing on screen showed that the download had finished and the next click would restart. The restored progress card makes each step visible. An audit of every other way an install can start without a click (a stale installRequested or installsWhenStaged, the idle install, the newest-build fetch) found none that a Download click can reach.

Tests

UpdateOneStepTests.aDownloadThePersonAskedForShowsItsProgress, aBackgroundDownloadShowsNoSidebarCard, theRestartButtonIgnoresAClickRightAfterTheCardAppears. The assertions #33176 changed in UpdateAsksBeforeInstallTests, UpdateDownloadCancelTests and UpdateLoadingIndicatorTests are back to the asked-for download showing on the card. The red commit (df417fcfb1d) comes before the fix.

Observed / Not run

Observed: prepush gate clean. The fleet compile and test results are added below once they finish.

Spec: plans/cmux-next/sidebar-owner.md (2026-11-04 entry; replaces half of the 2026-11-03 entry from #33176).

Changelog

Fixed: after you click Download, the update's download progress shows in the sidebar again.

Agent session: agent session

🤖 Generated with Claude Code

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by cubic

Restores the sidebar download progress card after clicking Download or Update, and guards against clicks that land on the Restart to Update button right as it appears.

Bug Fixes

  • A download the user asked for shows its progress (and Cancel) on the notice card until staged; background downloads still stay quiet.
  • The Restart to Update button ignores pointer presses for 1 s after the card takes over the slot; key and VoiceOver presses are never ignored.