base red: webviews design tokens (What's New brief) and the transcript spacing test's after() helper

Merged
LA
3d ago
+26-7

Summary

Two web-lint base reds on feat-cmux-next, one commit each:

  1. bun run check:design-tokens: new design token violation (1 > 0): pages/changelog/updateSurfaces.css spacing margin-top 2px, from #34477 (b7c9441d175). .wn-pop-brief .wn-pop-more now uses var(--ds-space-1) (4px), the gap .wn-pop-all already uses above it. The look moves by 2px.
  2. webviews typecheck: test/transcript-spacing-kinds.test.ts:247: Cannot find name 'after'. #34464 (1e8a45ba8ce) removed the below()/after() helpers; #34370 (8557b1002b6), written on a base that still had them, added a new after(...) call. The two merged one after the other. This restores both helpers exactly as #34370 measured with them. No other test change.

Changelog

none

Observed / Not run

  • Ran on this branch: bun run check:design-tokens passes; scripts/web-lint.sh passed (webviews), including the type check; prepush-gate.py no new violations.
  • Not run: the browser run of transcript-spacing-kinds (it runs in the webviews browser lane). Leo (author of #34370 and #34464) should confirm the waiting-to-live gap still means what #34370 intended now that message rows are on one line.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the base reds on feat-cmux-next so the branch's web lint (format, type, and lint gates) passes again.

  • .wn-pop-more now uses var(--ds-space-1) (4px) instead of a hardcoded 2px, matching the gap .wn-pop-all uses above it — the look moves by 2px.
  • Restores the below() and after() helpers in the transcript spacing test that were removed after the test added a new after() call.
  • Builds the cloudRun test call label with String(params.cwd) to satisfy the restrict-template-expressions lint.
  • Reformats App.tsx, emojiShortcodes.test.ts, and composer-emoji.browser.test.ts to match vp fmt --check; no behavior change.
  • Updates the cloudRun source-check regex to allow whitespace between the granting(...) arguments, which the format pass split onto multiple lines.