base red: Settings' progress fill is not a surface; the model menu's + draws at 12px
Merged
TE
3d ago+8+8+0123456789-2-2-0123456789
Fixes two webview base reds that every feat-cmux-next push run since #33176 / #32980 shows (for example 41742234192 at 842ce345 and 41745017210 at 4165f6f0):
webviews/src/pages/settings/render.test.tsx"no rule declares a background other than transparent or the two interaction tokens": regressed by #33176, which added.app-update-progress::-webkit-progress-valueand::-moz-progress-barwithbackground: var(--text). A progress bar's value fill is not a surface, so the test now exempts only those two progress-value pseudo-elements at that value. Containers stay checked, and the neutral bar #33176 shipped stays as it is.webviews/test/check-icon-scale.test.ts: regressed by #32980. The model menu'sPlusIcon(QuickModelColumns.tsx) drew at 11px, off the scale. #32980 landed about an hour after the check itself (#33595). The icon now draws at 12px, which is on the scale, matches its 12 viewBox and matches the CheckIcon beside it. The baseline only shrinks, so raising it isn't allowed.
Model picker surface: design/model-picker.md says nothing about icon size; this changes the + by 1px.
Agent session: agent session
🤖 Generated with Claude Code
![Autofix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png)
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.
Summary by cubic
Fixes two webview base reds by updating the settings render test and the model menu's PlusIcon size.
- The render test now exempts progress-bar value fills (
::progress-valuepseudo-elements) from the surface check, since a progress bar's filled part is its value, not a surface. - The model menu's
PlusIconnow draws at 12px instead of 11px, matching itsviewBoxand theCheckIconbeside it, and putting it back on the icon scale.