fix(sidebar): public import Observation in GroupJoinHold (compile red since #33578)

Closed
LA
3d ago
+1-1

Base red, priority zero. Debug and Release compiles of feat-cmux-next fail since f0db13630a7 (#33578):

GroupJoinHold.swift:85:2: error: cannot use protocol 'Observable' in a public or '@usableFromInline' conformance; 'Observation' was not imported publicly

GroupJoinRows is a public @Observable class, so the file needs public import Observation.

This is the same one-line change as #33653 (credit: teamleaderleo). That PR's only commit has no Sidebar-Look: trailer, so its own fast gates is red (the sidebar-owner gate), and a reword would need a force push. This PR is one commit that has the trailer Sidebar-Look: no visual change. Whichever lands first fixes the tip; the other then has no diff.

Changelog

none

Observed / Not run

  • Observed: python3 scripts/cmux-next/prepush-gate.py: no new violations. A fleet compile check runs on the head (result in a comment).
  • Observed: #33653 (the same diff) passed cmux-next/compile and cmux-next fleet Release compile.
  • Not run: tests. No behavior change; this is an import visibility change.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by cubic

Fixes a compile error in feat-cmux-next where GroupJoinHold.swift uses Observable in a public conformance without publicly importing Observation.

This is a one-line import visibility change with no behavior change.