base red: arch app_lines +1 from #33155 (the hub's comment rides on the hub's line)

Merged
LA
3d ago
+1-2

Fixes the +1 part of the arch-ratchet red: [app_lines] CmuxNextApp Swift lines: +1 at 41f05ffcd61f (judged over 6500d46a95f4). Culprit: #33155 (a848b28fded), the only commit in that range that adds an App line.

Takes back #33155: no code changes; a comment line joins a code line.

Cause

#33155 added AgentPaneTailCache.shared.resume() in CloudService's sign-in observer: +1 CmuxNextApp line.

Fix

The comment line under it ("Sign-out revoked the WireGuard peer and parked the hub.") now rides on the line it describes, await self.hub?.resume(), as #33019 did. The code is the same.

Red at the base, green at the head

Command: python3 scripts/cmux-next/arch-ratchet.py --base PARENT --head COMMIT

  • Red at a848b28fded over its parent: +1 (CmuxNextApp +1).
  • This head over the current tip: app_lines -1 (CmuxNextApp -1), no count rises.

The tip is red again for a larger reason: e8fc11865f8 (#33567) adds +74 App lines. That needs moves to packages and gets its own PR.

Changelog

none

Observed / Not run

Observed: the ratchet runs above; prepush-gate.py passed. Not run: no build (a comment move only).


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the arch-ratchet red for CmuxNextApp App lines by merging a comment onto the code line it describes.

The +1 App line came from #33155, which added AgentPaneTailCache.shared.resume() and a comment on a separate line. This PR keeps the code identical and moves the comment onto the await self.hub?.resume() line, matching the pattern from #33019. Net result: app_lines -1, no other counts rise.