fix(cmux CLI): a list that lacks the window's workspace reads the window again with the barrier (#32201 follow-up)
Summary
Follow-up to #32201 (CLI-1: workspace list reads the app window without the app's read barrier). #32201 merged at its first reviewed head (8185ff03), before this fix for that review's Medium finding (https://github.com/manaflow-ai/cmux/pull/32201#issuecomment-6576122764) reached it.
The gap: cmux workspace close <the workspace the window shows>; cmux workspace list. The app's last published snapshot, which #32201 reads with after: 0, can still show the closed workspace. The overlay then marks every row unfocused until the app publishes again.
Fix: when a workspace list of the app's session lacks the workspace the app's window shows, the snapshot is older than the daemon's answer, so the overlay reads the window once more with after: "sync". Every other list keeps the single fast read. app_workspaces takes the barrier; the with_read_barrier doc names a caller-chosen after.
Owner: the cmux CLI (cmux-tui/crates/cmux-tui).
Changelog
none
Testing
Regression test: a_list_without_the_window_s_workspace_reads_the_window_again_with_the_barrier (cmux-tui, cli/app_focus/tests.rs): a fake app answers after: 0 with the pre-close window and after: "sync" with the post-close window; the list must read twice and take focused from the second read.
- Red at a4becc242f3 (test only): step c2fa4f6b7296e35a068a74f6 FAILED as expected.
- Green at f283afe98f3: step 01118f2a36a6f700a5b23b6e, app_focus and agents tests 14 of 14. Clippy step 52e03a0f: red only in
mux/tests/read_paths.rs, the known base red from #32177 that #32282 fixes; no finding in this PR's files. - The same two commits on the #32201 branch: red step 0b0f825ef5a8431668352fd5 failed as expected (one
after: 0read only); green step 3c90020eb58a5a13f5a46cf6, app_focus and agents tests 14 of 14. Independent review of those commits: SHIP at 82312c5f64a (https://github.com/manaflow-ai/cmux/pull/32201#issuecomment-6576784635); a new review covers this head.
Observed / Not run
Observed: the red and green steps above. Not run: an app round with a close then a list under load.
![View with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3-3x.png)
![Autofix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png)
Need help on this PR? Tag @codesmith-bot with what you need.
Summary by cubic
Fixes the workspace close <shown> then workspace list case where the overlay marked every row unfocused because the app's last published snapshot still showed the closed workspace. When a list of the app's session lacks the workspace the window shows, the overlay now reads the window once more with after: "sync"; every other list keeps the single fast read, and the read barrier's doc now notes the caller-chosen after.