fix(app): register debug.creation.hold and debug.close.hold again (lost in #28295's merge)

Merged
TE
4d ago
+1-1

debug.creation.hold / debug.creation.release and debug.close.hold / debug.close.release are registered again on a Debug build's control socket.

#29409 (P0 close-then-type) registered the local daemon's creation-hold and close-read-hold methods beside debug.daemon in AppControl:

service.router.register(DebugWindowsControl.methods(services) + [services.daemon.debugControlMethod { … }] + services.daemon.creationHold.methods + services.daemon.closeReadHold.methods)

#28295 (debug.daemon_requests, b9abd53794bb) landed after it with its own copy of that line, which added debugRequestLatencyMethod() and dropped both hold lists. Nothing else on feat-cmux-next registers them (git grep "creationHold.methods" finds no caller), so a Debug app answers those four methods with an unknown-method error. scripts/cmux-next/typeahead-gate.sh and the journey fuzz (scripts/journeys/ext_fuzz.py) drive them. #28295's own description doesn't mention removing them, so this looks like a merge loss. This PR puts them back beside debug.daemon_requests. It's a one-line change.

Found while investigating the cmux-next crash ends the app base red. That red is not caused by this, and this PR does not fix it. See the follow-up evidence on the crash-gate diagnostic PR.

Checks: app compile check passed at e467a95109b1cd29564a2738d65e4db267abae2f; scripts/cmux-next/prepush-gate.py reports no new violations.

Agent session: agent session

šŸ¤– Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Restores debug.creation.hold/release and debug.close.hold/release on a Debug build's control socket. #28295 replaced the registration line in AppControl and dropped both hold lists, so Debug builds answered those four methods with an unknown-method error. This puts them back beside debug.daemon_requests. It's a one-line change; this does not fix the cmux-next crash ends the app red it was found investigating.