fix(cmux-tui-core): snapshot_written takes the snapshot's end as one value (base red: clippy too_many_arguments)

LA
3d ago
+39-12

Summary

Base red on feat-cmux-next: cargo clippy -D warnings refuses cmux-tui-core on every push and every PR since #31931 (e3c495d3baf2). The error is this function has too many arguments (8/7) at cmux-tui/crates/cmux-tui-core/src/output_store/snapshot.rs:537, because #31931 added the stream-gap count as an eighth argument of snapshot_written.

The three values that say where a written snapshot ends (generation, stream_end, gaps) are now one SnapshotEnd value. These are the same fields that Capture::Snapshot carries. The one caller and the three tests pass it. There is no behaviour change, and no #[allow].

Found by dogfood-ports while it ran clippy for #32055. No STATUS item or open PR owned it.

Testing

Fleet, at head 98581fa4a2a:

Observed / Not run

Observed: the fleet steps above. Not run: the full cmux-tui-core suite (only the output_store filter, which covers every caller).

Changelog

none


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the clippy too_many_arguments failure in cmux-tui-core that made every push and PR to feat-cmux-next red.

snapshot_written grew an eighth argument, so the three values describing where a written snapshot ends (generation, stream_end, gaps) now travel as one SnapshotEnd value, the same fields Capture::Snapshot carries. There is no behavior change; the single production caller and the three tests pass it.