base red: agent_chat_notices clippy (obfuscated if/else, a missing ;, a redundant clone) from #31770

Merged
LA
4d ago
+7-5

The cmux-tui workspace clippy (-D warnings) is red on feat-cmux-next since #31770 (947bb5e00d7, cache-TTL idle reminders). It fails on three errors in cmux-tui-core/src/mux/agent_chat_notices.rs:

  • :147 clippy::obfuscated_if_else: a bool.then(..).unwrap_or_default() chain. It is now an if/else.
  • :209 clippy::semicolon_if_nothing_returned: a match arm whose unit call had no ;.
  • :1462 clippy::redundant_clone: a test's spec.clone() that nothing used after.

No behavior change.

Seen first on #31863's clippy step at 70edc9b7bf5b (job 4aa99ea44b82505765387a3c), whose head merged that feat tip.

Changelog

none

Observed / Not run

Observed (fleet, Linux, scripts/ci/cmux-tui-rust-check.sh clippy):

  • red, base fc013e84c65e (feat tip): job 7492e369e26b34a4b1eb0198 FAIL on exactly the three errors (agent_chat_notices.rs:147:27, :209:17, :1462:30).
  • green, head e7ecb66ba00c: job d90b0149d43f295aba8406b5 cmux-tui-rust-check: green (cargo clippy --workspace --exclude cmux-holder-v3 --all-targets --locked --keep-going -- -D warnings; hq run 41400004617), so no crate that depends on cmux-tui-core has another error.

Not run: tests (the change is a refactor of one expression, a ; and one test literal).