base red: a reply's hover time stays shown while its menu is open (check:popup-hover-reveals, #31609)

Merged
LA
4d ago
+2-0

Summary

check:popup-hover-reveals in webviews is red on every feat-cmux-next push since #31609 (de9d3bb3c1c). That PR shows a reply's time on :hover of .acpmux-turnSummary and .acpmux-assistant, but it did not add the :has([data-popup-open]) selector that every hover reveal must have. When the pointer moves from the reply into its menu, the time hides and the buttons stay.

This PR adds the two :has([data-popup-open]) selectors, as .cv-turn-actions already has. The time stays shown while a menu from that reply is open. No exemption is added.

Changelog

none

Testing

Command: (cd webviews && bun run check:popup-hover-reveals)

  • Base 8e630df614f: red, 2 lines at conversation.css:3828.
  • Head: "popup hover reveals: all reveals keep their controls open".

Observed / Not run

  • Observed: the command above, red at base and green at head; prepush-gate.py has no new violations.
  • scripts/web-lint.sh has one other red, which is on base: check:design-tokens (updateSurfaces.css, fc4ad465bae), which #31639 fixes. I pushed with CMUX_WEB_LINT_SKIP_REASON that names it.
  • Not run: no browser test of the hover state. This is CSS selectors only.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Adds the :has([data-popup-open]) selectors that #31609 omitted when it added hover reveals for reply times, so the time stays shown while the pointer is in the reply's open menu. This turns check:popup-hover-reveals green again after being red on every webviews push.