ci: skip ci-status on pull requests into feat-cmux-next
Merged
TE
5d ago+23+23+01234567890123456789-11-11-01234567890123456789
Leo asked: "what ci status job seems unnecessary"
Into feat-cmux-next, ci.yml's ci-status is not a required check and can only pass: its verdict step prints "feat-cmux-next uses cmux-next" and exits 0. Even so it:
- held a runner while it waited on every job it
needs(webincluded) for a verdict it never read; - showed up as one more pending check that landers waited on;
- gave
delta_since_greena green head even whenwebhad failed on it.
Change
.github/workflows/ci.yml:ci-statusskips pull requests intofeat-cmux-next, label events included. #29747 kept it running on label events so that a skippedci-statuswould never hide an earlier red one fromgh-merge-green. On this base it was never red, so a skip hides nothing.main,merge_groupand stacked next-line PRs keep it as before.scripts/gh-merge-green: no longer requiresci-statuson basefeat-cmux-next; it still requires thecmux-nextruns there. This script is not the landing path forfeat-cmux-next, but run by hand it would otherwise refuse with "run CI for the pull request head".- next-autoland already treats
ci-statusas advisory (test_ci_status_is_advisory), so landing does not change. The CLAUDE.md line that said next-autoland requiresci-statuswas stale and is corrected. - Tests: two
gh-merge-greenrefusal tests that used a missing or redci-statusonfeat-cmux-nextnow refuse on a redcmux-nextrun.test_ci_change_areasasserts the newif:.
Changelog
none
Observed / Not run
- Ran:
python3 -m unittest tests.test_gh_merge_green(113 OK);tests/test_ci_change_areas.py(the same 4 failures as on base, none about ci-status); test_ci_label_events_skip_full_ci, test_ci_guard_workflow_structure, test_ci_required_checks_are_bounded, test_ci_required_checks_drift, test_next_batch_groups, test_ci_delta_since_green, test_ci_queue_janitor, test_base_red_excuse, test_web_validation, test_ci_workflow_run_sources and test_pr_red_checks_comment all pass. - Not run: a live CI run; this PR's own run is the first to show
ci-statusskipped.
Risk: high, because it changes gh-merge-green, the risk gate's enforcer. No Swift, so no compile is needed.
Leo-ask: ask-f5270bcf0f
Agent session: agent session
š¤ Generated with Claude Code
![View with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3-3x.png)
![Autofix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png)
Need help on this PR? Tag @codesmith-bot with what you need.
Summary by cubic
Skips the ci-status job for pull requests into feat-cmux-next, where it was not required and could only pass, so it no longer holds a runner, shows as a pending check, or reports a false green when web failed.
ci.ymlnow skipsci-statusfor PRs intofeat-cmux-next, label events included;main,merge_group, and stacked PRs keep it.gh-merge-greenno longer requiresci-statuson that base; thecmux-nextrun checks stay.- Fixes a stale
CLAUDE.mdnote aboutnext-autolandrequiringci-status. - Updates tests: refusals on that base now key off a red
cmux-nextrun, and the newif:condition is asserted.