base red: eval_upsell expects the Plus plan that d3340c16ef9 added to the paid-plans skill

Merged
LA
8d ago
+1-1

Summary

Base red: the_paid_plans_skill_ships_with_the_checkout_command_and_the_never_rules (Native/OptChat/optchat-chief/tests/eval_upsell.rs:37) fails on every optchat-chief run, both in Linux CI and on the macOS fleet, with skill lacks "cmux billing checkout --plan <pro|max|team>".

d3340c16ef9 ("cmux NEXT plans: sell cmux Plus and match classic Cloud limits") changed the paid-plans skill to <plus|pro|max|team> on purpose and did not update this test. With this PR, the test expects the current plan list of the skill.

I do not revert d3340c16ef9. We revert first when a change breaks the tip by mistake. d3340c16ef9 added Plus on purpose, and only its test expectation is stale. A revert would remove a product feature (the Plus plan, its backend Cloud limits and its CLI alias) only to fix one line in a test.

Follow-up gap, not in this PR: the Chief prompt (Native/OptChat/chief-kernel/src/prompt.rs:455 and its golden files) still says checkout --plan <pro|max|team>, so the prompt does not name Plus.

Testing

Focused command (fleet):

cmux-ci run --class isolated --script scripts/ci/cmux-tui-rust-check.sh --ref SHA --arg optchat-chief --arg the_paid_plans_skill_ships
  • Red on the base: feat 038bf00cc91 fails at eval_upsell.rs:37 5 of 5 (steps 32985ab9, 3cfdf956, 367d52bc, aa89890f, 7d878a1d on aws-m4pro-3, -4, -6 and -8). #28820's GitHub CI on Linux fails the same way.
  • Green at the head 1b40b001b2b2ddb27d23f5b8cc48f31f036184d9: step f84dddb9ee6cc6f49f029b17 (aws-m4pro-8): the_paid_plans_skill_ships_with_the_checkout_command_and_the_never_rules ... ok; clippy and fmt pass.

Observed / Not run

Observed: prepush-gate.py found no new violations. The base red is in the logs above.
Not run: no Chief eval run (the change is only in a test).

Changelog

none