base red: revert the unasked-detect red test (aec7054d44b) until its fix lands
What
A base red, priority zero. rust workspaces / Native/OptChat/optchat-chief is red on feat-cmux-next since aec7054d44b (01:57Z):
memory_sync_state::tests::unasked_detect_never_lists_downloads_or_desktop ... FAILED
panicked at src/memory_sync_state.rs:461:9: detect listed a protected folder: [... Downloads/data-2026.zip ..., ... Desktop/claude-export.zip ...]
aec7054d44b is a red-first test that was pushed directly to feat without its fix. The red is deterministic (detect still lists ~/Downloads and ~/Desktop), not a flake. Red on every feat push that runs the job: 41157767497 (aec7054d44b), 41160504930 (babe9dc522a), 41160969309 (c91791229a6). Also red on PRs, for example 41159553538 (lane/ao-takeover-22030).
Lawrence's order is revert first, then fix. This PR reverts the test commit only.
The fix must bring the test back. The fix is bc8b414147a (detect_with_exports, with the Swift Import Memories caller) on origin/a-lazy-permissions. It has no PR and it is not on feat. When it lands, it must revert this revert in the same PR. A merge of that branch does not touch these lines, so it drops the test with no conflict.
Command: cmux-ci run --class isolated --script scripts/ci/cmux-tui-rust-check.sh --arg optchat-chief --arg memory_sync_state --ref SHA
- Not run on the fleet (see below). On the base, CI shows the panic on every run.
Changelog
none
Observed / Not run
- Observed: the CI logs above (the same panic on 3 feat pushes and on a PR).
python3 scripts/cmux-next/prepush-gate.py: no new violations. - Not run on the fleet: I cancelled the base and head runs when the coordinator gave the follow-up fix to another owner. The red evidence is the CI logs above, and its removal is a test-only revert.
- Not run: the other optchat-chief CI steps (clippy, fmt). This PR only removes a test module function.
![View with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3-3x.png)
![Autofix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png)
Need help on this PR? Tag @codesmith-bot with what you need.
Summary by cubic
Reverts the unasked_detect_never_lists_downloads_or_desktop test from memory_sync_state.rs, which was pushed to feat-cmux-next without its fix and made CI deterministically red.
The fix lands in detect_with_exports on a-lazy-permissions; when it merges, this test must be brought back in the same PR.