base red: acpmux: macOS clippy dead start_logged; arithmetic ratchet back under its baseline
Two acpmux lint base reds on feat-cmux-next.
1. macOS clippy: function start_logged is never used
cargo clippy -D warnings on macOS (job fb8745cdbcf3231af7557c1d, aws-m4pro-4, at #28041's merged head) fails at cmux-tui/crates/acpmux/tests/daemon_memory.rs:82. #27991 (941b7a4b133) moved Daemon::start onto start_inner, so start_logged has one caller left, retained_session_list_allocation_benchmark, which is #[cfg(target_os = "linux")]. Fix: start_logged is #[cfg(target_os = "linux")] too.
2. Panic ratchet: acpmux arithmetic_side_effects over its baseline 1430
The tracked count grew from the baseline that #28169 (66c3d03e88e) measured (warning now). From the ratchet's clippy JSON at 66c3d03e88e (cmux-tui-spec run 41076340459) and at a current feat head (run 41086018852), per file:
| merge | file | new hits | now |
|---|---|---|---|
| 4543835b0ae (#28161) | hub/session_pages.rs | 3 (len() + 1, used + bytes twice) | saturating_add |
| 55df6404b06 (#28353) | daemon/unused_exit.rs | 2 (clients += 1, arrivals += 1) | saturating_add |
7a5538d2c6a (#27868) removed one in agent_host/host.rs. No value here can reach usize::MAX or u64::MAX, so behavior is the same. The baseline is not lowered here: a lower count needs the Linux measurement of this PR's own ratchet run.
Evidence
| run | result | |
|---|---|---|
| macOS clippy before (feat tip 4ab956c5620) | fleet 5937adaa407e3121bf249dd6 (aws-m4pro-2) | fails: associated function start_logged is never used |
| macOS clippy after (c73f1cce9c96, the dead-code fix alone) | fleet b62faf44852ef09f28767510 (aws-m4pro-2) | passes |
| Linux clippy after (c73f1cce9c96) | fleet bf122b19e08a2d0c4e790703 | passes (Linux never had the warning) |
| ratchet after (head) | this PR's cmux-tui-spec run | pending |
R9: no new cap, limit or timeout.
R10: no hot path changes.
Observed / Not run
- Observed: the runs above;
prepush-gate.pypasses. - Not run: the ratchet at the head (it runs in this PR's checks).
Changelog
- none
No capture: no UI change.