cmux NEXT menus: the No Color swatch's tip is themed, not the stock tool tip (base red)

Merged
AZ
11d ago
+14-1

NativeTooltipGuardTests.noViewDrawsTheStockTooltip fails on every pull request whose cmux-next swift test runs (for example #21233). The offender is CmuxNextDesign/MenuIdentityHeaderView.swift:267: raw toolTip =, which c3bd2b29c6b9 added for the No Color swatch. Base pushes skip swift test, so the base never shows this red.

The No Color swatch's tool tip is now themed, set with setThemedToolTipRegions over that swatch, instead of the stock toolTip. The themed tooltip works inside a menu:

  • its tracker is a tracking area, and the strip's own hover ring already gets those events in this menu
  • its delay is a main-actor task, which the menu's tracking run loop drains
  • its panel sits at the pop-up menu level

It's a region set at init and on every frame size, because a tracking area added under the pointer gets no mouseEntered. The other swatches still have no tip, as before.

Verification

  • cmux-ci run with package-test-lane.sh suite Packages/macOS/CmuxNext NativeTooltipGuard,MenuIdentityHeader,WorkspaceNoColor,SidebarMenuLook at ec28542896e0 passes all four suites. On the base, NativeTooltipGuard is red in #21233's swift test job.
  • Not checked live: hovering the No Color swatch in a running build. The review covered why the themed tip shows in a menu.

No capture: the change is the tip shown while hovering the No Color swatch inside an open menu; a still capture of the menu looks the same before and after.

Changelog

none

šŸ¤– Generated with Claude Code