cmux NEXT: disable broken Needs your input pill by default

Merged
TE
7d ago
+55-7

Summary

The floating “Needs your input” pill is unreliable across chats. Keep it off by default while retaining the Debug Settings opt-in and the separate Needs you list. The opt-in pill cycles only through supported local targets; peer and unknown other-chat entries remain in the separate list. Cross-chat navigation stays on the native tab-opening path.

Prior art: 4d7ccb1162b9 on origin/sp-needsyou removed the bottom pill after Leo's feedback; #23849 preserves the source chat by opening another tab. This change keeps the existing opt-in surface while containing the broken default.

Depends on #24440 for inherited text-focus and formatting check repairs; land that PR first.

Testing

Head 51cb12c679dfdf801f0e1c917752a66c5c00de5b: bun test test/agent-pane-needs-you.test.tsx passes 24/24. Full bun run check passes structural guards, formatting, lint, type checking (2406 files), and protocol generation. Tests cover refusal without source scrolling and exclusion of unsupported pill targets. The waiting-label test now compares exact label text rather than counting a substring also present in the permission label.

Observed / Not run

  • prepush-gate.py: no new violations. verify-local.py --only localization-defaults --only package-groups --only feature-flags: 3/3 pass on this exact head.
  • Managed native test step 8debe8e22bd542941185a7c2 passed on aws-m4pro-2 at this exact head: AgentPaneNeedsYouTunablesTests (5 tests), AgentPaneThoughtTunablesTests (8), and AgentPaneAskOpenTests (2). Package/test compilation and all 3 suites passed; downloaded summary digest ad952afe5ed0048a48692c31c02114632fcadcd52d749fc7dd5c83357f4cbb07.
  • Astra independent review: SHIP at this exact head; primary review also passes.
  • Gallery display and keyboard-focus checks pass at this exact head. The native bridge is mocked there: actual target-tab reuse, duplicate-open prevention, and native cross-chat interaction remain unverified.
  • Full localization parity was not rerun after the base refresh; this change adds no text. Existing system-blue warnings return zero and are unchanged.
  • No user-facing strings or localization catalogs changed.

Landing status: the ci-status gate has not reported on this head; one 180-second condition wait timed out. Owner: codex-7 on cosmic-gray. Resume from the existing CI receipts, land #24440 first, then hand this exact head to next-autoland. No duplicate CI dispatch is needed.

Changelog

Fixed: The unreliable Needs your input pill is off by default and its opt-in navigation skips unsupported chats.

Proof

Reference: Claude's apps/claude/live/session-running-with-side-panels.png and composer-status-row-below.png in manaflow-ai/cmux-design-references, which keep the footer quiet and put secondary status beside the conversation.

Claude referencecmux NEXT default-off gallery
Claude referenceDefault-off gallery

Opt-in gallery state. These are real component captures from the canonical Vite gallery, not native-app interaction evidence. The installed nightly predates this branch.

No capture: Live native chat/tab interaction was not exercised. The default attribute paths are covered by source review and the managed native tests; the gallery uses a mocked native bridge. The pill stays off by default while that live path remains unverified.

Agent session: cosmic-gray