crash-class: probe NSView firstBaselineOffsetFromTop into the selector table

Merged
TE
14d ago
+3-0

Base red: cmux-next crash-class rules fails on every PR (e.g. #24025, #24327) with "probe needed" for super.firstBaselineOffsetFromTop in HoverCardIconSlot.swift:27 and HoverCardRow.swift:278 (added by 1231b9d30d3). The fix is the checker's own repair: check-objc-selectors.py --probe --write on a Mac, then commit the table. NSView answers the selector on macOS 27.0.1; that is the one entry added.

Changelog

none

Observed / Not run

  • Ran python3 -I scripts/cmux-next/check-objc-selectors.py at base 8fa72367: 2 failures, the ones above. With this table: 0 failures.
  • Probe ran on cosmic-gray (macOS 27.0.1) in a scratch copy. It uses ctypes against libobjc only, with no build.
  • Not run: probes on other macOS versions. The checker holds a key probed on one version to that version only.

Agent session: huge-blue

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the cmux-next crash-class check failing on every PR because the selector table had no entry for super.firstBaselineOffsetFromTop, used by HoverCardIconSlot and HoverCardRow. The checker now passes with 0 failures.

  • Adds the probed NSView get:firstBaselineOffsetFromTop/0 entry for macOS 27.0.1 only; the checker keys probes to the version they were run on.
  • The probe was run with ctypes against libobjc on macOS 27.0.1 with no build; other macOS versions were not probed.