cmux NEXT right sidebar: the Files and Find header and list share one surface

Merged
TE
15d ago
+27-0

Summary

Live QA of nightly 1.0.0-nightly.3965802926201 (3a63d6d) found that the right sidebar's Files and Find sections had a band across the top in a different color from the list below it. The header strip shows the window's background, while the list underneath is a .sourceList table, which paints the system sidebar gray at alpha 0.8. This started with 56d448575ce (the Files section became a file explorer).

  • FileExplorerSectionView and FindSectionView keep the .sourceList style but set table.backgroundColor = .clear. The list now sits on the window's background like the header strip above it and the left sidebar.
  • Nothing else changes: row selection, the source-list style and the left sidebar are untouched.

Testing

  • New RightSidebarSectionBackgroundTests checks that each table's background alpha is 0. It is committed before the fix: on the base both tables report alpha 0.8 (checked with a standalone AppKit probe of a .sourceList NSTableView), and with .clear they report 0.

Observed / Not run

  • Observed: prepush-gate.py reports no new violations. check-no-godfiles.sh and check-theme-scope.sh report only base findings in files this PR doesn't touch. The Swift syntax check passes.
  • Not run: the Swift tests. Agents don't compile on this host, so CI runs them.

No capture: a one-property background change on two tables; I'll attach a capture from the next nightly.

Changelog

Fixed: the right sidebar's Files and Find sections no longer show a band of another color under their header.

Agent session: cmux16

🤖 Generated with Claude Code

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Summary by cubic

Fixes the right sidebar's Files and Find sections showing a band of a different color under their header.

The lists keep the .sourceList style but now set table.backgroundColor = .clear, so the list sits on the window's background like the header strip and the left sidebar. Row selection, the source-list style, and the left sidebar are unchanged.

Testing

  • Adds RightSidebarSectionBackgroundTests verifying both tables paint with a background alpha of 0.