cmux NEXT chat: a pending question reads "answer the question below", not "allow this?"

Merged
TE
14d ago
+69-8

Ready. Reviewed SHIP at 460e669; remaining reds are base.

In a Full access chat an agent asked a multiple-choice question (AskUserQuestion), and the running turn's line read "Waiting for you: allow this?". acpmux sends an agent's question as a permission request, so the chat's pending ask carries it as question, and chatWaitsOn treated any pending ask as a permission.

chatWaitsOn now takes the pending ask itself. An ask carrying a question waits on an answer ("Waiting for you: answer the question below"). A plain tool permission still reads "allow this?".

Commits: the failing test first (waitingOn.test.tsx), then the fix.

Changelog

Fixed: an agent's question no longer shows as "Waiting for you: allow this?" in the chat.

Observed / Not run

  • Not run here: the webviews tests and bun run check (CI runs them; this Mac runs no test suites).

No capture: the change is one line of text, chosen by state; the unit test covers both states.

Agent session: Air-Blue

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the chat's waiting line when an agent asks a question in a Full access chat: it now reads "answer the question below" instead of "allow this?". acpmux sends an agent's question (AskUserQuestion, Codex user input) as a permission request, so the pending ask carries the question. chatWaitsOn now takes the pending ask itself and distinguishes a question from a plain tool permission.

  • A pending ask carrying a question waits on an answer; a plain tool permission still reads "allow this?".
  • App.tsx passes the pending ask through instead of a boolean, and tests cover both the Claude and normalized question shapes.