cmux NEXT Settings > Chief: Look holds the pet, the characters and Bubble Style on one glass card

Merged
TE
14d ago
+350-55

Summary

Settings > Chief redesign, card 2 of 4 (Chiefs #23851, Look, Behavior, Diagnostics; Leo's list #89(2)). How the Chief looks is now one glass card, titled Look:

  • The pet: its preview with Show Pet / Hide Pet, then the characters. Every Chief surface wears the chosen character.
  • Bubble Style: at the card's foot. Before, it stood alone below the pet as a one-row "Chief Chat" card, which is now gone. Search, the palette and cmux settings still reach the row, and ?focus=home.chiefBubbleStyle lands on it inside Look.

Changes:

  • ChiefPetCard is the Look card: it is .ui-glass, has the settingsPage.chief.look title (21 locales), and draws home.chiefBubbleStyle (added to CHIEF_PET_ROWS, so SectionView leaves it out of the group list).
  • Glass card CSS: a direct title sits on the 16px text edge, and the part before the rows (the characters) keeps 16px clear of their hairline.
  • New gallery state pages.settings / chief-look-bubbles (focus on Bubble Style).
  • No Swift change. The Swift layout still lists the row in its schema group, so ChiefSettingsPageTests holds.

Before / after (gallery pages.settings, 16x9 window)

Before (base cc945e2)After (head 24fd900)
before, pet card, darkafter, Look, dark
Bubble Style was a separate one-row Chief Chat card below the pet.after, Look foot with Bubble Style, dark
after, Look foot with Bubble Style, light

No capture: Settings > Chief is the Settings web bundle. The gallery before/after above renders that page; the only native-side change is one string catalog entry, with no Swift UI code.

Test

bun test src/pages/settings/chiefLook.test.tsx

  • Red at e280d64 (on cc945e2): 3 fail. The card had no title and no glass, Bubble Style was in its own settings.group.chiefChat card, and focus didn't land inside Look.
  • Green at fcc9f3a: 3 pass.

Observed / Not run

  • Observed on cmux16 at 24fd900:
    • bun run check: exit 0. The one warning, check-system-blue on ui/importCards.css, is in a file this PR doesn't touch.
    • bun test src/pages/settings src/pages/home-channels: 263 pass, 0 fail.
    • Gallery: base cc945e2 vs head 24fd900, built and shot with Playwright.
  • Not run: no Swift build (only an xcstrings entry is added in a Swift package catalog, no code) and no native capture.

Changelog

  • Changed: Settings > Chief shows the pet, its character and Bubble Style together on one Look card.

Agent session: huge-blue

🤖 Generated with Claude Code