cmux NEXT Settings > Chief: a Notices row opens Notifications
Merged
TE
11d ago+472+472+012345678901234567890123456789-3-3-0123456789
Summary
Settings > Chief ends with a Notices row: "The Chief's notices follow your notification settings." Its Open Notifications button opens Settings > Notifications. The row copies none of Notifications' controls, so every setting keeps its one home on the page (SettingsPageLayoutHomeTests).
SettingsPageLayout.Card.notices, the Chief category'strail.webviews/src/pages/settings/components/NoticesCard.tsx: oneActionRowthat pushes#/settings/notificationsthrough the page router, so Cmd-[ comes back.- Three
settingsWindow.chief.notices.*strings in all 21 locales. settings-schema.jsonis generated: the PR autofix regenerates the export'spage.
No capture: a single web settings row; the gallery's pages.settings Chief state shows it after the schema regenerates.
Tests
webviews/src/pages/settings/chiefNotices.test.tsx: the Chief page has the Notices row, its button routes to Notifications, and no Notifications row is drawn on the Chief page.ChiefSettingsPageTests.chiefEndsWithANoticesLinkAndNoNotificationRows(Swift).
Observed / Not run
- At 80b300cc2ad (red):
bun test src/pages/settings/chiefNotices.test.tsxfails, with "Expected: "Notices", Received: undefined". - At the head, with the export's Chief
trailpatched by hand as the regeneration will write it: that file plus categories, chiefPetCard and chiefsCard tests, 20 pass.scripts/web-lint.shandprepush-gate.pypass. - Not run locally: the Swift test (no local Swift); CI runs it.
Changelog
- Added: Settings > Chief has a Notices row that opens Notifications.
Agent session: huge-blue
š¤ Generated with Claude Code
![View with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3-3x.png)
![Autofix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png)
Need help on this PR? Tag @codesmith-bot with what you need.
Summary by cubic
Settings > Chief now ends with a Notices row that opens Settings > Notifications instead of copying its controls, so every notification setting keeps its one home on the page.
- The row is the Chief category's
trail, drawn by the newNoticesCardthat routes through the settings page router so Cmd-[ returns. - Adds
settingsWindow.chief.notices.*strings in all 21 locales, sized to fit the 60-character help limit, plus thenoticescard to the schema; the settings exports were regenerated. - Covers the behavior with a web test and a Swift layout test asserting no Notifications rows appear on the Chief page.