cmux NEXT palette: the Priority row actions' chat picker lists chats in the picker test (base red)

Merged
TE
15d ago
+34-5

Summary

PalettePickerSourcesTests.everyRequiredTargetArgumentListsItsObjects has been red on feat-cmux-next since #23527. It fails at :100 with:

sidebar.priority.markRead chat (agent-chat)
sidebar.priority.togglePin chat (agent-chat)
sidebar.priority.snooze chat (agent-chat)

All three actions ask which chat. PriorityChatTargetSource read the app's AgentPriorityChats.app, which reads this Mac's and the Chief's live acpmux lane stores, so the picker list in the test was empty. The test builds its own AppServices and couldn't seed those stores.

PaletteSourcesBridge.targetSource now takes chats:, defaulting to .app, so the app behaves as before. The suite passes two seeded Priority chats, built the way SidebarPriorityRowActionsTests builds them. A new test, thePriorityRowActionsListThePriorityChats, checks that each of the three actions lists exactly those chats.

The other red from #23527 needed nothing here: #23597 (c2bab662bc80) already retitled sidebar.priority.togglePin from "Pin or Unpin Chat in Priority" to "Pin/Unpin Chat in Priority…". In the row menu, ActionTargetTitles names it Pin or Unpin from the chat's state. ContextMenuShapeTests and PaletteMenuVocabularyTests pass on #23597's swift test job (job).

No capture: nothing on screen changes. The app's palette lists the same Priority chats as before. Only the chat source became a parameter (default .app), so the picker test can pass in its own chats.

Testing

cmux-next swift test runs PalettePickerSourcesTests.everyRequiredTargetArgumentListsItsObjects:

  • Base: it fails with the three rows above, on #23597's run (job) and #23545's run (job).
  • This head: CI on this PR will show the result.

Observed / Not run

  • Ran:
    • check-app-size.sh --base origin/feat-cmux-next: no App source-line growth (100636 before and after). Adding the import is offset by folding two lines into one.
    • prepush-gate.py: no new violations.
  • Not run locally: the Swift tests, which a local build guard blocks on this Mac. They run on this PR's CI.

Changelog

none

🤖 Generated with Claude Code

Agent session: cosmic-gray

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Summary by cubic

Fixes the priority row actions' chat picker test, which has been red since #23527: the three actions (mark read, pin/unpin, snooze) ask for a chat, but the picker read the app's live AgentPriorityChats.app stores, so the picker test's list was empty.

PaletteSourcesBridge.targetSource now takes chats:, defaulting to .app so the app behaves as before. The picker test seeds two Priority chats and a new test verifies all three actions list exactly those chats.