cmux-next tests: RemoteChildSessionsTests' fake client states isReadOnly (base red: tests don't compile)

Merged
TE
15d ago
+1-0

Summary

Base red: CmuxNextAppTests doesn't compile on feat-cmux-next, so no Swift test suite of the CmuxNext package can run. The cause is a semantic merge break between two PRs:

  • #21258 (cc6fde59b11f) made isReadOnly a requirement of AgentSessionRemoteClient.
  • #23163 (c2b90f6d9e04), merged after it, added RemoteChildSessionsTests.FakeClient without that property.

The fake stands in for a writable daemon attachment, so it now declares let isReadOnly = false.

Testing

  • Red: a fleet run-swift-testing-suites.sh Packages/macOS/CmuxNext run on base 4a6ef5b94a5d fails to build: RemoteChildSessionsTests.swift:14:37: error: type 'RemoteChildSessionsTests.FakeClient' does not conform to protocol 'AgentSessionRemoteClient' (note: protocol requires property 'isReadOnly').
  • Green: the same fleet run on this head (46916d21b03b) gets through build-and-list (233 s), compiles CmuxNextAppTests RemoteChildSessionsTests.swift with no error, and starts the suites.

Observed / Not run

Observed: the red and green fleet builds above. Review: an independent review subagent passed it. It confirmed isReadOnly was the only missing requirement, and that false changes no assertion: these tests only send _acpmux/watch, which never reads the flag. It also confirmed the other two conformers already declare it.

Not run: I merged before the fleet suite run finished, so the suites' results aren't in yet.

Red on this head that isn't this PR's: cmux-next checks fails on Companion workflows, because scripts/cmux-next/base-autofix-repair.sh doesn't exist in that job. That's a workflow-script problem; this PR changes one Swift test file.

Changelog

none

Agent session: cosmic-gray

🤖 Generated with Claude Code