cmux-next tests: SidebarRowGutterTests expects the sidebar pill's trailing trim from #22733

Merged
TE
17d ago
+10-3

Summary

SidebarRowGutterTests has been red on feat-cmux-next since #22733 (0d6230334c8c, "row pills stop short of the edge"). That PR made every sidebar row end SidebarStyle.rowTrailingTrim (Metrics.space4, 8 pt) before the list's right inset, so the pill never reaches the sidebar's edge (Leo 2026-10-20: "trim the pill's right side"). It did not update this suite, which still expected the pill to end exactly at the inset and at the divider's right edge.

The change was deliberate, so the test is what's out of date and this PR is test-only:

  • selectedAndUnselectedRowsHaveEqualLeadingAndTrailingInsets: the pill's right inset is horizontalInset + rowTrailingTrim. The checks that the content's leading and trailing insets inside the pill are equal, and that the pill's left inset is the gutter, stay the same.
  • thePillAlignsWithTheSectionHeaderAndTheDivider: the pill ends rowTrailingTrim before the divider's right edge. Its left edge still lines up with the header and the divider.

No product code changes.

Evidence

  • Command: cmux-ci run --class light --script scripts/ci/package-test-lane.sh --arg=suite --arg=Packages/macOS/CmuxNext --arg=SidebarRowGutterTests --env CMUX_CI_XCODE_APP=/Applications/Xcode_26.6.app
  • Red on base 27ed89644ee2: fleet step 0675fe8cc69e7a258abc3dd8. At :69 the trailing inset is not the gutter, and at :81 pill.maxX 226 != aboveLine.frame.maxX 234 (exactly the 8 pt trim).
  • Green on head 21785c019f0e: fleet step 3167c900cb816a8856eed142, 3/3 tests passed.

Observed / Not run

  • Observed: the base red step above and the head green step (Xcode 26.6, package-test-lane). The prepush gate is clean.
  • Not run: other suites. Builds on a newer tip (d483541226a2) currently fail to compile in CmuxNextPagesTests/PageEnginePolicyTests.swift:43, a separate base red. That is why this branch is based on 27ed89644ee2, the tip the red step ran on.

Changelog

none

Agent session: cosmic-gray

🤖 Generated with Claude Code

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Summary by cubic

Updates SidebarRowGutterTests to match #22733's deliberate trim, which now ends each sidebar pill SidebarStyle.rowTrailingTrim (8 pt) short of the sidebar's right edge. The suite has been red on feat-cmux-next since that change; this PR is test-only with no product code changes.

  • The pill's right inset is now horizontalInset + rowTrailingTrim; its left inset and the equal content insets inside the pill are unchanged.
  • The pill now ends rowTrailingTrim before the divider's right edge instead of exactly at it.