webviews: the run board's attach and replay strings come from the pane's string table (base pane-english red)
Merged
TE
15d ago+1068+1068+0123456789012345678901234567890123456789-13-13-01234567890123456789
Base webview red: test/pane-english.test.ts has failed on every feat-cmux-next web run that ran the shards since #22408 (802f9b7aa24, the Run board). Nine user-visible strings in run-board/runAttach.ts and run-board/runApi.ts were written in English instead of the pane's string table.
Change
- The strings go through the pane's table (
translatefromacpmux/i18n.ts): the four attach errors, the invalid-ticket error, the two replay errors and the "Agent output" row title. All of these reach the screen:RunBoard.tsxandTimelineRunBoard.tsxshow a caughtRunApiHttpError's message in their alert, and "Agent output" titles a transcript row. - 8 keys added to
acpmux/Localizable.xcstringsin all 21 shipped languages:runBoard.error.attachExpired,attachTransportUnsupported,attachEnrollmentRequired,attachNoSession,attachInvalidTicket,cursorStalled,replayPageLimit, andrunBoard.agentOutput. Non-English text is markedneeds_review, like the neighbouring keys. - Error codes (
run_attach_expiredetc.) are unchanged. The two replay errors now start with a capital letter, since they show in the alert. - No check was loosened, and there are no
l10n-allowexemptions.
Changelog
none
Observed / Not run
- Red on base db57fbc06d76 (local, bun 1.4.2):
bun test test/pane-english.test.tsgives 0 pass, 1 fail, with the 9 findings. - Green on this head: 1 pass.
bun test src/agent-session/acpmux/run-boardgives 25 pass, 0 fail.bun run check:catalog-keysis clean. - Base CI: in the last 15 base web runs that ran the shards, pane-english failed in 13 of 13 runs from 802f9b7aa24 on and passed in the 2 runs before it.
scripts/web-lint.shfails only oncheck:text-focus, the base red fixed by #23300 (merged).- Not run: the translations have not been reviewed by a native speaker (
needs_review). - Follow-up, not in this PR:
RunBoard.tsx:258,TimelineRunBoard.tsxandCompareRunBoard.tsxstill have similar English literals that the scanner does not flag.
Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag @codesmith-bot with what you need.
Summary by cubic
Fixes the run board's attach and replay errors showing in English, which failed the pane-english test on every web run since the Run board shipped.
- Routes nine user-visible strings (four attach errors, the invalid-ticket error, two replay errors, and the "Agent output" title) through the pane's string table.
- Adds eight
runBoard.*keys toacpmux/Localizable.xcstringsin all 21 languages, with non-English text markedneeds_review. - Error codes are unchanged, and the two replay errors now start with a capital letter since they appear in the board's alert.