ci: the real signing import test carries the Developer ID G2 intermediate

Merged
LA
21d ago
+13-2

Summary

Follow-up to #21145 (cmuxterm-hq#2053). The real macOS import test (tests/test_signing_keychain_real_import.sh, from #21142) now builds its throwaway .p12 with the vendored Apple Developer ID G2 intermediate in the chain, as the CI certificate secret has. The real scripts/ci/signing-keychain.sh create then runs the real scripts/import-apple-developer-id-intermediates.sh against a keychain that already holds that intermediate. That is the path that failed in the first main nightly after #21043 (run 38857402565).

No secret: the identity is self-signed and made in the job; the workflow has no environment and contents: read.

Testing

Changelog

none


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Makes the real macOS signing import test carry the vendored Apple Developer ID G2 intermediate in its throwaway .p12, matching the CI certificate secret. This reproduces the nightly failure from #21043 where the intermediates step met the G2 intermediate already in the keychain, and the test now asserts it took that path so the fix is actually verified.

Summary by CodeRabbit

  • Tests
    • Expanded signing-keychain checks to cover importing an identity that includes the Developer ID G2 intermediate certificate and verify that the intermediate is already present in the keychain.
    • Test output is now shown when creation succeeds, and failures include the captured log to make the result easier to diagnose.