fix: CmuxNextApp size cap: move SidebarSameTurn into CmuxNextSidebar

Merged
TE
22d ago
+7-8

Fixes the base size-cap red I caused with #20709: on feat-cmux-next tip 9d70c8abb75a, CmuxNextApp had 113,729 lines against a cap of 113,692 (+37). Every push to feat and every PR that adds App lines failed the "CmuxNextApp size cap" check.

SidebarSameTurn (42 lines) only uses SidebarView and ObservationStream, so it moves into CmuxNextSidebar, which already depends on CmuxNextCompat. Its type and methods become public. SidebarBridge in the app still owns and drives it. There is no behavior change and no Package.swift change.

Verification

  • scripts/cmux-next/check-app-size.sh --base origin/feat-cmux-next .: before (tip), capped at 113692 lines (now 113729), a failure. After: ok, CmuxNextApp has 113687 lines, 5 under the cap 113692.
  • scripts/cmux-next/check-concurrency.sh: ok.
  • Fleet Release compile on the head: running. SidebarSameTurnTests is unchanged and runs in PR CI.

Changelog

none

šŸ¤– Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Brings CmuxNextApp back under its size cap by moving SidebarSameTurn into CmuxNextSidebar. The app's SidebarBridge still owns and drives the instance; the type and its methods become public. No behavior change and no Package.swift change.

  • CmuxNextApp is now at 113,687 lines, 5 under the 113,692 cap.