Fix native sidebar footer Help and account menus

AU
20d ago
+377-515

Summary

Fixes #17631. The sidebar footer Help and account controls now open real AppKit NSMenu instances from their existing footer buttons. Account menus keep the identity header and account actions, including Switch Account and Sign Out; Help actions are grouped with native separators and retain configured shortcut glyphs. The old Command-hold shortcut footer popover is removed because the shortcut list is available from Help.

This ports the native-menu approach from contributor PR #14893; Leo Li is credited in the implementation commits and the existing PR remains open for maintainer direction.

Testing

Updated SidebarHelpMenuUITests and CloudTeamPickerPlacementUITests to require native menuItems, verify that the footer controls do not create popovers, cover the restored Switch Account action, and preserve the existing update, feedback, Settings, account, and Cloud picker behavior checks.

Passed locally:

  • python3 scripts/verify-local.py --all (16/16 static checks)
  • ./scripts/localize-changes and python3 scripts/localization_catalog.py check (10 catalogs, 9 locales)
  • python3 scripts/wire-app-sources.py --check
  • git diff --check

The branch includes origin/main at 3e7ed5a562ae (the fetched main tip, green CI guards). Native Swift compilation and UI execution require macOS/Xcode and are covered by the required CI jobs.

Changelog

Changed: Sidebar footer Help and account controls use native macOS menus.

Proof

Required CI provides native compilation and changed-suite UI coverage; this Linux checkout has no macOS GUI session for a live capture.

Checklist

  • Behavior changes have added or updated tests
  • UI/menu change was localized and the catalog audit passed
  • User-facing docs are not needed for this behavior change
  • Reviewed with a subagent before merge