Focus Sidebar and Focus Pane 1…9 are unbound by default (restore pre-#19324/#19263 defaults)

Merged
TE
19d ago
+65-31

Leo's review of classic changes merged without a call: #19324 (Ctrl+Cmd+E, Focus Sidebar) and #19263 (Ctrl+Cmd+1…9, Focus Pane 1…9) added new default keys. This restores the old default: both are unbound. The actions stay in the command palette and in Settings > Shortcuts, so people can bind them.

  • ShortcutAction+Defaults.swift (package table) and KeyboardShortcutSettings.swift (app table): both actions default to unbound.
  • web/data/cmux-shortcuts.ts: no combo, "unbound by default" note (en/ja).
  • Socket tests: the DEBUG debug.shortcut.set learns focus_sidebar and pane_digits. test_focus_sidebar_keyboard.py checks that Ctrl+Cmd+E does nothing by default, then binds it. test_focus_pane_by_number.py binds the key first.

Austin was mailed (team mailbox) the full list of classic changes for his calls; this one was already decided by Leo.

Verification

  • Red (test only, f3cd5189): focusSidebarAndFocusPaneByNumberAreUnboundByDefault in CmuxSettingsTests; fleet run-swift-testing-suites.sh Packages/macOS/CmuxSettings.
  • Green (4ec36726): same command.
  • The tests_v2 socket tests need a tagged app build; not run (they run in the app-host lanes).

Changelog

  • Changed: Focus Sidebar (was Ctrl-Cmd-E) and Focus Pane 1…9 (was Ctrl-Cmd-1…9) are unbound by default; bind them in Settings > Shortcuts.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Restores the old default for Focus Sidebar and Focus Pane 1…9: both are now unbound instead of Ctrl+Cmd+E and Ctrl+Cmd+1…9. Those defaults were added without approval in #19324 and #19263. The actions remain in the command palette and Settings > Shortcuts, so users can bind them.

  • The debug.shortcut.set socket command now accepts focus_sidebar and pane_digits; the sidebar test verifies Ctrl+Cmd+E does nothing by default, and the other tests bind the keys before exercising them and then restore the unbound default.
  • Docs (cmux-shortcuts.ts), the package and app default tables, and the pane-number handler comments reflect the unbound defaults.

Summary by CodeRabbit

  • Changes
    • Sidebar focus and pane-by-number shortcuts are no longer assigned by default. You can still bind them in shortcut settings.
    • Shortcut configuration now recognizes additional names for sidebar focus and pane-number navigation.