test(webviews): heal the gallery-coverage and ui-rules base red (no bead)

Merged
TE
1mo ago
+73-1

Summary

web / react-apps-check failed on 9 of the 10 PR runs after 12:35Z. These are base reds on feat-cmux-next a15fefe54f69:

  • gallery-coverage was missing pages/home-channels/AddChannel.tsx#AddChannel, MessageRow.tsx#DraftRow, icons.tsx#HomeIcon (from 3aedbdcf28ed and 9f8d556ccaed) and pages/settings/components/ThemeTokens.tsx#ThemeTokens (from 1657e2b620a7).
  • ui-rules flagged a new raw onKeyDown at pages/home-channels/EmojiPicker.tsx:59 and a stale pending count, MessageRow.tsx: 0 < 1.

The repair:

  • home-channels: mechanical only. Three allowlist lines, plus a pending entry for EmojiPicker.tsx and removal of the stale MessageRow.tsx entry. No logic changes.
  • ThemeTokens: a real gallery entry, pages.settings.theme-tokens, with three variants: as shipped, one edited token, and locked.

Verification

  • Base 8a47499cb815: bun test test/gallery-coverage.test.ts test/ui-rules.test.ts fails 3 tests (red).
  • This branch: the same command, plus the gallery tests, passes with 0 failures (green).
  • bun run check (format, lint, types, layers) passes, and tsc --noEmit is clean.
  • Browser lanes run in CI only.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes the base-red webviews test failures in react-apps-check: gallery-coverage was missing three home-channels components and ThemeTokens, and ui-rules flagged a new raw onKeyDown in EmojiPicker.tsx plus a stale pending count for MessageRow.tsx.

  • Adds a functional gallery entry for ThemeTokens (as shipped, one edited token, locked) that draws its edits through the real settings tokens and locale, plus allowlist entries for the home-channels components.
  • Updates the ui-rules pending entry from MessageRow.tsx to EmojiPicker.tsx; home-channels changes are test metadata only, no logic changes.