refactor(ci): remove redundant platform rollup runner

Merged
TE
1mo ago
+120-137

Summary

  • fold the platform routing verdict into the existing required ci-status job
  • remove the standalone tests Linux rollup runner and its duplicate dependency hop
  • remove a duplicate Xcode selection step from the opt-in dogfood build

This avoids one Linux runner allocation per noncancelled CI run, modeled as up to five runner-minutes. It does not claim a measured wall-clock improvement. Published build and release gates are unchanged.

Validation

  • python3 tests/test_ci_change_areas.py
  • python3 tests/test_ci_cli_product_routing.py
  • actionlint .github/workflows/ci.yml
  • python3 scripts/verify-local.py --affected HEAD --repo /Users/leoli/Projects/cmux-worktrees/ci-lean-rollup-main
  • git diff --check

Changelog

Changed: remove a redundant CI routing runner and duplicate dogfood setup step.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

[!NOTE]
Medium Risk
Moves required platform routing logic into ci-status and tweaks cancellation handling; merge gating behavior should stay equivalent but any drift would affect every PR.

Overview
Removes the standalone tests Linux rollup job and runs the same Check platform workflow routing Python gate as the first step of the required ci-status job instead. Downstream jobs no longer list tests as a dependency; the script now reads PLATFORM_NEEDS and only treats cancellation on changes, linux-preflight, macos, and web as a blocked verdict.

Failure attribution drops the retired tests job from GATE_JOBS in classify_failures.py. Dogfood build loses a duplicate Select Xcode step before GhosttyKit download.

Tests and routing checks are retargeted from the tests job to ci-status / run_platform_gate.

Reviewed by Cursor Bugbot for commit 9f17af758df7669b95a5e089f6e1324fb7648f56. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by cubic

Streamlines CI by removing the standalone tests rollup runner and folding its platform routing verdict into the existing required ci-status job. Also removes a duplicate Xcode selection step from the opt-in dogfood build and drops the retired job from failure attribution. This avoids one Linux runner allocation per noncancelled CI run while leaving published build and release gates unchanged.

Summary by CodeRabbit

  • Chores

    • Updated CI status checks to validate platform results, Linux preflight, and required macOS and web workflows.
    • Removed a redundant Xcode-selection step from the dogfood build.
    • Updated failure reporting to include failures from the test job and adjusted CI timing checks.

  • Tests

    • Updated CI routing checks for platform results, including failure and skip handling for macOS and web workflows, and Linux preflight behavior.