Skip no-op tab metadata updates

Merged
AZ
3mo ago
+62-0

Summary

  • add a regression test proving no-op tab metadata updates should not invalidate observation readers
  • return early from BonsplitController.updateTab when every supplied field matches current metadata

Verification

  • swift test --filter BonsplitTests/testNoopTabUpdateDoesNotInvalidateObservedTabMetadata
  • swift test

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Summary by cubic

Skip no-op tab metadata updates so identical values no longer invalidate observers or mutate state. This prevents needless SwiftUI observation churn and redundant work.

  • Bug Fixes
    • Early return in BonsplitController.updateTab when all supplied fields match current metadata.
    • Added regression test BonsplitTests/testNoopTabUpdateDoesNotInvalidateObservedTabMetadata to ensure observers aren’t invalidated on no-op updates.