Accept the eight measured side-bearing findings and verify both slopes
Merged
RI
3d ago+1051+1051+0123456789012345678901234567890123456789-236-236-012345678901234567890123456789
What changes
The weight ladder of Warp now reads verified with accepted findings for both slopes. Fontspector reports eight new suspicious_sidebearings warnings. They come from the static styles, so the 350 and 450 masters cannot remove them. The ladder tool now lists them and checks the list in both directions.
- Findings. Roman: the
ellipsisadvance width at wght 350, 449.98779296875 and 450.006103515625 (z-scores 10.0 to 13.7). Italic: the same three forellipsis, plus thezcaronright side bearing at the last two (z-score 11.5). The check warns above a z-score of 10, measured against the spread over all glyphs at that location. - Causes. The ellipsis dots are spaced by the stem-dependent dot diameter, so the advance varies more than for any other glyph. The Italic
zcaronright side bearing steps by 19 units between the static masters 400 and 500. Each entry inproofs/warp/accepted_findings.jsonholds its check id, code, glyph, locations, measured z-scores and cause. - Rule.
warp/tools/vf_ladder.pyrecords the z-score of each finding. The verdict isverified with accepted findingswhen the findings outside the baseline equal the list exactly, andnot verifiedwhen a listed finding is gone or an unlisted one appears.
Evidence
| Check | Result |
|---|---|
| Ladder run from the saved aligned sources, Fontspector on a 14 GB host | Roman 5 WARN, Italic 7 WARN, 0 FAIL, 0 FATAL, 0 ERROR; numerical gates true; 0 start-point findings |
New tests, pytest warp/tests -k ladder_findings | 17 passed; replacing the rule by "always verified" fails 6 of them |
pytest warp/tests | 161 passed |
| Variable font sizes | 7,448,792 and 6,679,608 bytes, below the 9,437,184 limit; equal to the sizes in the committed report |
warp/scripts/build.sh, then git status --porcelain -- fonts/warp | prints nothing: the static styles are byte for byte the committed ones |
The Fontspector run needs about 11.7 GB and 22 minutes per variable font, so it does not run in CI.
Summary by CodeRabbit
- Improvements
- Verification reports now distinguish successful checks with documented findings from runs with no findings.
- Reports include measurements and locations for side-bearing findings, making it easier to review them.
- Finding comparisons flag both unexpected findings and previously accepted findings that are no longer present.
- Documentation
- Updated project records and changelog with the latest verification results, including eight documented side-bearing findings.