Fix: workflow fixes from the v1.12 release testing
BR
11h ago+1001+1001+0123456789012345678901234567890123456789-78-78-01234567890123456789
Description of your changes
Five fixes from the v1.12 release testing and its review, one commit each, best reviewed commit by commit:
- Fix(http): bound a workflow HTTP request's time and response size
- Fix(http): read a step's TLS Secret only from its own namespace
- Fix: stop completed side-effect steps of a WorkflowRun running again
- Fix: fail a step whose $( ) if cannot be evaluated
- Fix(http): check the IPv4 address a NAT64 address carries
Each commit message says what was wrong and what changed. kubevela/kubevela picks these up for the 1.12 release
(it needs httpguard.RequestTimeout and ReadResponseBody from the first).
I have:
- All commits are signed off (DCO).
How has this code been tested
Every fix has a test written first that fails on main and passes with the fix. The unit suites pass, and the
WorkflowRun fix was also checked against a k3d cluster.
Special notes for your reviewer
The first commit adds two controller flags, --max-workflow-http-timeout and --max-workflow-http-response-bytes,
exposed in the chart under workflow.http.