fix(integration-make-com, integration-zapier): answer the default settings when the integration is not configured
Merged
CE
7d ago+163+163+012345678901234567890123456789-10-10-01234567890123456789
Problem
IntegrationTenantService.findOneByOptions throws NotFoundException on a miss and never returns null, so the "not configured" branch of getIntegrationSettings was unreachable in both plugins:
- Make.com: the outer catch swallowed the
NotFoundException, so a tenant without the integration gotundefined(an empty 200) instead of{ isEnabled: false, webhookUrl: null }. - Zapier: the error was rethrown, so the settings endpoint answered 404 instead of its
isEnabled: falsedefault.
Fix
The lookup turns NotFoundException into null (as ActivepiecesService does), so the existing default is returned; other errors are still rethrown.
Tests
New make-com.service.settings.spec.ts and zapier.service.settings.spec.ts: default on NotFoundException, stored settings mapped when the integration exists, other errors rethrown.
Notes
Not built or run locally.
Summary by cubic
Fixes the settings endpoints for Make.com and Zapier integrations so tenants without an integration configured receive the proper default response instead of an empty 200 or a 404.
- Handles
NotFoundExceptionfromfindOneByOptionsas "not configured", returning{ isEnabled: false }defaults with relevant null/false fields; other errors are still rethrown. - Adds unit tests for the make.com and Zapier settings services covering the default, mapped settings, and error rethrow paths.