fix(config): reject timeouts above the timer limit
Merged
BA
4d ago+69+69+01234567890123456789-12-12-01234567890123456789
What and why
timeout,launchTimeout,actionTimeout,assertionTimeout,cleanupTimeout,app.command.startupTimeout/shutdownTimeoutandagents.<name>.judgmentTimeoutnow go throughtimerMs(packages/e2e/src/config/validate.ts) instead ofpositiveInt. A value above 2147483647 ms isINVALID_CONFIG, like the CLI flags andmaxDurationalready are.- A test's or group's own
{ timeout }gets the same bound incollect/registry.ts, so it fails collection instead of timing out at once. positiveIntis unchanged, since it also guards non-timer integers.- Docs: the limit is noted in
docs/reference/config.mdx(top-level rules) anddocs/reference/test.mdx(timeout). Patch changeset fore2e.
Issue
Fixes #1739
Verified
Ran it locally: yes
- New unit tests per key family (config top-level,
app.command,judgmentTimeout, test/describetimeout) fail onmainand pass here. e2e runinapps/testbedwith a config that setstimeout: 3_000_000_000:
| main | this branch |
|---|---|
config accepted; every test fails at once with TEST_TIMEOUT (the issue repro) | INVALID_CONFIG (config) timeout must be at most 2147483647 milliseconds, got 3000000000, exit 2 |
Checklist
- Changeset added (
pnpm changeset) for any change to a published package, or the change is testbed, docs, or CI only. - Breaking change: title carries
!, the changeset body names what breaks and what replaces it, and the deprecation warning landed a window earlier (stability policy in CONTRIBUTING.md). - Docs updated in the same PR: the
docs/**/*.mdxpage for the behavior, andskills/e2e/if the skill describes it. - Contract change: emitted
.d.tsreviewed,tests/types/sdk-types.tsupdated; wire change edits the schema and both fixtures. - Engine contract change (
e2e/engine): changesets fore2e,@e2e-dev/web, and@e2e-dev/mobile.