fix(e2e): send `duration` from fake Vercel createDeployment after @vercel/sdk 1.28.37 bump

Merged
KE
3h ago
+16-2

Summary

Fixes the guided_deployment.spec.ts Vercel test that has failed every attempt on main since the @vercel/sdk 1.28.35 → 1.28.37 bump (#4699). Failing run: https://github.com/dyad-sh/dyad/actions/runs/40823341469. It failed 6/6 attempts across the macOS and Windows shard 2 jobs.

  • Root cause (deterministic): in 1.28.37, every branch of the SDK's CreateDeploymentResponseBody schema requires a duration object. All of duration's own fields are optional, and 1.28.35 had no such field. The fake Vercel POST /v13/deployments returned only { id, readyState, aliasAssigned, target }, so the SDK threw ResponseValidationError on an HTTP 200. getVercelDeploymentError then showed "Vercel deployment failed (HTTP 200). Dyad could not read Vercel's response…", and "Building on Vercel…" never appeared. The CI page snapshot shows that alert. I checked this by running safeParse with the 1.28.37 schema: the old fake body's only error is duration: Required, and the new body passes.
  • Fix: the fake response now includes duration: { startTime: createdAt }.
  • Secondary race (1 of 6 attempts, Windows retry): the click on "Production database" timed out because the Deploy dialog had already closed. prepareDeploymentApp reloads the window, and the startup chat restore re-selects the app. The main log shows "No app selected for preview" followed by "App 1 selected for preview" about 75ms after the deploy-button click. DeployButton resets deployAppId whenever appId changes, so the dialog closed. A real user can't click Deploy within about 100ms of the window booting, so I fixed this in the test, not the app. DeployDialog.open() now retries inside expect.toPass, reopening the dialog if it has gone, and waits for the dialog's Step N — … heading.
  • Reviewer check: the SDK will now also require duration from the real Vercel API. The SDK is generated from Vercel's OpenAPI spec, so production presumably returns it, but I have not checked this against the real API. If Vercel ever omits it, real deploys would fail with the same HTTP 200 error.
  • Not addressed: in one local full-file run, the Vercel test failed at an earlier step. GitHub createRepo showed "Failed to auto-commit uncommitted changes", and no app logs were captured. It did not happen in CI or in the next three local runs.
  • Also adds two triage learnings to rules/e2e-testing.md: fake servers must satisfy the SDK's response schemas, and reading the html-report error-context snapshots first.

#skip-bugbot

🤖 Generated with Claude Code