Fix step exit code references in examples

Merged
YO
2d ago
+4-4

Summary

Three graceful-degradation examples read a step's exit code from ${env.<STEP_ID>_EXIT_CODE}. Dagu has never set such a variable, so the precondition never matched and the fallback step was always skipped (item 4 of dagucloud/dagu#3033). The examples now use the supported ${<id>.exit_code} reference.

The queue page also now states that a dag.run child starts directly rather than through its queue, so the queue's max_concurrency does not limit it. The reporter of #3033 expected otherwise.

Changes

  • writing-workflows/continue-on.md: ${try_optimal_method.exit_code}, ${check_primary.exit_code}
  • writing-workflows/control-flow.md: ${try_advanced_method.exit_code}
  • writing-workflows/queues.md: one sentence on dag.run and queue limits

Validation

Ran a DAG locally with a step that exits 7 under continue_on: failed. The ${env.FLASH_EXIT_CODE} precondition skips the step; ${flash.exit_code} runs it.

Related: dagucloud/dagu#3461

Summary by cubic

Fixes three graceful-degradation examples that read a step's exit code from the unsupported ${env.<STEP_ID>_EXIT_CODE} variable, which Dagu never sets, causing the fallback step to always be skipped. The examples now use the supported ${<id>.exit_code} reference (dagucloud/dagu#3033).

Also clarifies in the queues doc that a dag.run child starts directly rather than through its queue, so the queue's max_concurrency does not limit it.