land: windows-configure-checkpoint-tests

Merged
AF
2h ago
+106-29

Accepted agent delivery; branch-keyed search descriptor included.


Summary by cubic

Fixes two Windows-flaky tests in crates/aft and adds a benchmark slice descriptor for this branch; no production behavior changes.

  • The configure cancellation test no longer expects configure to reach a stubbed git probe within a deadline; the stub holds its first attempt in flight until the test releases it, and the assertion is now exact (no further attempts after cancel) instead of allowing one raced attempt.
  • The checkpoint rollback test no longer writes its fixture to the system temp directory, which intermittently refused access on Windows, and its blocking path is now the parent directory created by the first restore, so the write fails and the rollback actually runs instead of being rejected up front.

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge; no actionable issues were found.

Summary

This PR makes Windows-sensitive tests less dependent on temporary files and machine speed.

  • Checkpoint tests build entries in memory and reach rollback failures.
  • Configure cancellation tests hold the first probe until cancellation is signaled.

No actionable issues were found. Tests were not run.

Reviews (1) · Last reviewed commit: "release notes and search-quality descrip..." · Reviewed by Greptile