land: windows-long-running-fixture

Merged
AF
5h ago
+73-2

Accepted agent delivery; branch-keyed search descriptor included.


Summary by cubic

Fixes intermittent Windows test failures caused by the LONG_RUNNING_COMMAND fixture exiting immediately: cmd /c timeout /t 5 resolved GNU coreutils timeout under Git Bash (which rejects /t and exits 125), so kill tests sometimes caught the task already failed. Replaced it with a bare ping -n 6 127.0.0.1 — Git Bash strips /c and unquoted backslashes from cmd forms, but a bare ping resolves to System32's in every Windows shell and runs about five seconds. Added a test asserting the fixture is still non-terminal three seconds after spawn, and improved the reclaimed-root status assertion to surface the exit code when a failure happens.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues remain.

Summary

This PR replaces the Windows long-running fixture with ping -n 6 127.0.0.1.

  • Windows background-task tests use a command that stays alive long enough for kill checks.

The previous unnumbered finding is fixed: the command no longer contains the nested cmd call or Windows path that Bash could alter.

Reviews (2) · Last reviewed commit: "test: use a bare ping for the Windows lo..." · Reviewed by Greptile