merge-pr waits for the automated review and never leaves auto-merge armed

Merged
AF
2d ago
+438-40

Accepted agent delivery; branch-keyed search descriptor included.


Summary by cubic

merge-pr now waits for the Greptile Review of the exact head commit before queue admission, and never leaves auto-merge armed when it refuses or when the head changes.

Behavior

  • Unresolved review threads, across all pages, now dequeue the PR and disable auto-merge before refusing.
  • Auto-merge is disarmed before waiting for the review, and a new head push to an existing open PR disarms and dequeues it.
  • The landing script tolerates missing admission timestamps and detects queue removal without relying on them.

RetriggerView in GreptileConfidence Score: 5/5

The changes appear safe to merge; no new actionable issue was found.

Summary

merge-pr waits for the review of the exact head commit before submitting the PR.

  • Merge admission waits for Greptile Review on the current head.
  • Landing disarms auto-merge when a PR head changes or a thread stays open.
  • The landing waiter keeps tracking PRs while queue details arrive late.

All four earlier threads were manually resolved without explanation. The current code addresses their original concerns.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Start merge request] --> B[Disable auto-merge and leave queue]
  B --> C[Wait for review of exact head]
  C --> D{Success or neutral?}
  D -->|No| E[Refuse submission]
  D -->|Yes| F{Head unchanged?}
  F -->|No| E
  F -->|Yes| G[Read every page of review threads]
  G --> H{Remaining gates pass?}
  H -->|No| E
  H -->|Yes| I[Submit with pinned head]

Reviews (2) · Last reviewed commit: "mason: fix PR review gate and queue trac..." · Reviewed by Greptile