Storage sweep admission test: prove admission causally and reap its work

Merged
AF
1d ago
+147-31

Accepted agent delivery; branch-keyed search descriptor included.


Summary by cubic

Makes the storage sweep admission test causal so it verifies the admission contract without depending on wall-clock speed.

  • Holds the storage sweep worker until the test releases it and requires bind and deferred bash dispatch replies while it is held, with 30s hang guards; bash goes through real executor admission via a childless dispatch sentinel.
  • Captures and joins the held storage sweep worker before fixture teardown, including when assertions unwind, and registers the worker handoff in the list-surface exclusion.
  • Adds a benchmark slice descriptor for the test.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no new actionable issues were found.

Summary

Makes the storage sweep admission test check replies while the sweep is still held.

  • The admission test checks bind and bash replies before releasing storage sweeps.
  • Test teardown waits for the storage sweep worker to finish.

The change since the previous review adds only the list-check exclusion. No new actionable issues were found.

Diagram

sequenceDiagram
    participant T as Test
    participant W as Sweep worker
    participant E as Executor
    T->>W: Hold storage sweep
    T->>E: Submit equivalent bind
    E-->>T: Reply
    T->>E: Submit changed bind and bash
    E-->>T: Bind reply and bash dispatch result
    T->>W: Release sweep
    W-->>T: Finish
    T->>W: Join before fixture cleanup

Reviews (2) · Last reviewed commit: "Register the storage sweep worker handof..." · Reviewed by Greptile