Flake batch 29: rebind diagnostics test retries the non-blocking job snapshot

Merged
AF
1d ago
+24-1

Main's run 41117835406 (commit d3b75e87) failed subc::tests::rebind_wait_diagnostics_name_active_job_without_waiting_on_database_slot. The diagnostic printed root jobs (None means scheduler locked): None: the executor's root-job snapshot is a non-blocking read and reports None while the scheduler holds its lock, by design, so a single read can miss the held writer.

The test now retries the diagnostic for up to 10 s while it still holds the database slot, until the snapshot gets through. Every assertion is unchanged. It's the same class as the startup-deadline test fixed in #1212.

Test-only. Checked on the build server: the test passed 3 times, formatting and the Windows check passed.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the flaky rebind_wait_diagnostics_name_active_job_without_waiting_on_database_slot test.

The diagnostic read the executor's root-job snapshot once, and that snapshot reports None while the scheduler holds its lock. The test now retries the diagnostic for up to 10 s while the database slot is held, so the assertions check snapshot contents rather than lock timing. All assertions are unchanged; the change is test-only, with a slice descriptor for the flake batch.