With two model Lenses, the review admitted is the one the evidence names (#855)
Merged
DO
3d ago+24+24+01234567890123456789-8-8-0123456789
Part of #855: its third point, which the review of #859 found beside it.
What. With two model Lenses required, kernel/decide.py's _wanted_run admitted the first whatever Lens awaiting_review named. So once the first had reviewed, an item whose second Lens was asked would run the first again, to the Run ceiling.
- It now admits the review of the Lens the evidence names. Derive names one only from the model Lenses the configuration requires, so no guard is needed past that.
- The default configuration requires one model Lens, so nothing changes live.
- #855's other two points, the simulator and the explorer pushing a head that leaves the diff as it was, follow in their own pull request.
Record. None, unless the Factory Builder rules one: the rule, admit the review the State awaits, is unchanged, and this mends its reading for a second Lens.
Tests and mutants.
tests/test_decide.py::test_with_two_model_lenses_the_one_awaited_is_the_one_admittedfailed first, as the issue says: the evidence named the second Lens, andpr-reviewwas admitted again. It passes now.- The mutant "the first model Lens is admitted whatever the evidence names" is new, and "the act ceiling stops a Run" follows the new call.
- All 105 mutants of
kernel/decide.pyare killed.tests.test_decide,tests.test_transitionsandtests.test_issuepass, and so doesmake checks.
Readers (head ff5043a1):
| Reader | Findings | Disposition |
|---|---|---|
| Claude review | 1 minor | Taken in f1b0ee6b: the guard on a Lens the configuration does not require could not be reached through go(), and was tested only by a direct call to the private _wanted_run. Both go, and the test calls the Kernel through go() alone |
| Claude security | 1 minor | The same, taken |
| Carbon (gemini-4-carbon-high) | none | ā |
| Astra (gpt-6-astra) | none | ā |
| Kimi (kimi-k3.1-pro) | Kimi: 0 findings, 0 taken | ā |
š¤ Generated with Claude Code