Checks: each check is given its workflow run's id and its suite's conclusion, so a cancelled run is told from a later one on the same head (#681, step 2)
User description
Part of "A cancelled run of a Lens is superseded by a later run on the same head" (#681), step 2 of its plan: the port. It follows step 1, the trial P-65 fixture (#744). The Kernel's reading is step 3, a pull request of its own after this one. The simulator's case is "Simulator: a cancelled run of a Lens beside a later run on the same head, with run ids on its checks" (#749).
What changes
| Part | Change |
|---|---|
adapters/checks.py | QUERY asks each check run's checkSuite { conclusion }; it already asked workflowRun { databaseId }. check() writes run_id, the workflow run's id or null for a check no workflow ran, and suite_conclusion, GitHub's word lower-cased or null while the suite has not concluded. A field is left out only where GitHub's answer leaves its key out, as the trials recorded before QUERY asked it do. A value in any form but its own is refused, never read as none |
schemas/facts.schema.json | The two properties, optional, by the Factory Builder's ruling (B). Absent is no default: the Kernel will read no supersession from a check that lacks either, so a cancelled run's failure stands, which fails closed. The held-out cases carry facts/1 and cannot be changed by a lane, so making them required would break the eval until their owner moved them |
examples/facts.json, examples/invalid/facts.* | The example carries both fields; two counter-examples hold the shape: a run id of 0, and a conclusion not lower-cased |
tests/test_adapters.py | Checks::test_each_check_is_given_its_runs_id_and_its_suites_conclusion. It holds the following: QUERY asks both fields; the port writes both for every node of P-65's rollup, a cancelled run's failed judging check with its suite cancelled among them; a run id of 1 is read and 0, a string, a bool or null are refused; a suite's conclusion of no whole word, of another type or empty is refused; an answer leaving a key out leaves the field out; and facts/1 holds the same at the schema |
22 mutants, all killed. The 71 mutants of adapters/checks.py were all killed on the stacked branch, and the file is unchanged by the move.
Nothing reads the fields yet. sim/world.py, tests/support.py, the held-out cases and the other examples leave them out, which reads as before. No model Lens input is touched.
Verify
make checks passes; tests.test_adapters passes. Full verify is CI's.
Reviews
Read on the branch stacked on #744, whose port commits these are, unchanged but for the mutants' place in tools/mutants.py after the move onto main.
| Read | Head | State |
|---|---|---|
| Claude + security | be8a29fe | Nothing blocking. An absent workflowRun written as null, an id overstated as ordering runs, the counter-example's name and a lost assertion: fixed in 76e0c1ef and 4a6d9044 |
| Muse (Wonder Full) | be8a29fe | Three minor findings (an absent run key, the id-1 boundary, one whole word): fixed in 76e0c1ef |
| Carbon (gemini-4-carbon-high) | be8a29fe | Two majors and three minors, all mutant holes: each half of two guards, the run id asked, the block's place. Fixed in 5bdf6a89 |
| Astra (gpt-6-astra) | 5bdf6a89 | One major (the schema's own boundaries untested): fixed in 4a4792e6 |
🤖 Generated with Claude Code
CodeAnt-AI Description
Record check run IDs and suite conclusions to distinguish cancelled runs
What Changed
- Each check now includes its workflow run ID and suite conclusion, making a cancelled run distinguishable from a later run on the same commit.
- Checks without a workflow run report a null run ID; unfinished suites report a null conclusion.
- Older check records without these fields remain accepted and are not treated as evidence that a later run superseded a failure.
Impact
✅ Cancelled check runs distinguishable from later runs
✅ Unfinished check suites remain identifiable
✅ Missing run details do not clear failures
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
@codeant-ai ask: Your question here
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
@codeant-ai ask: Can you suggest a safer alternative to storing this secret?
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
@codeant-ai: Your feedback here
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
@codeant-ai: Do not flag unused imports.
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
@codeant-ai: review
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.